Add error handling for reading cached strings#2987
Closed
JudahGant wants to merge 1 commit intoAssemblyScript:mainfrom
Closed
Add error handling for reading cached strings#2987JudahGant wants to merge 1 commit intoAssemblyScript:mainfrom
JudahGant wants to merge 1 commit intoAssemblyScript:mainfrom
Conversation
CountBleck
reviewed
Mar 8, 2026
| } | ||
|
|
||
| /** Reads a cached string, throwing a descriptive error if null. */ | ||
| private readStringOrThrow(ref: number, context: string): string { |
Member
There was a problem hiding this comment.
Where is this method even used?
Author
There was a problem hiding this comment.
Sorry this was accidental, please ignore!
HerrCai0907
requested changes
Mar 9, 2026
Member
HerrCai0907
left a comment
HerrCai0907
left a comment
There was a problem hiding this comment.
why we need to change? Is there any related issue?
Member
|
Closing because this doesn't do anything. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # .
Changes proposed in this pull request:
⯈
⯈
⯈